Skip to content

refactor(elements): Fix loading oddities - #3648

Merged
tmilewski merged 3 commits into
mainfrom
tm.elements/fix-forgot-password-loading
Jul 1, 2024
Merged

refactor(elements): Fix loading oddities#3648
tmilewski merged 3 commits into
mainfrom
tm.elements/fix-forgot-password-loading

Conversation

@tmilewski

Copy link
Copy Markdown
Member

Description

Sign In

  • Rename route: to step: for consistency.
  • Clean up loading logic thus negating the need for context

Fast-Follow: Apply similar changes/logic to sign-up.

Fixes SDK-1863

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@tmilewski
tmilewski requested review from LekoArts and brkalow July 1, 2024 20:21
@tmilewski tmilewski self-assigned this Jul 1, 2024
@changeset-bot

changeset-bot Bot commented Jul 1, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3a0689e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/elements Patch
@clerk/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewski
tmilewski requested a review from panteliselef July 1, 2024 20:22
@tmilewski

Copy link
Copy Markdown
Member Author

!snapshot

@clerk-cookie

Copy link
Copy Markdown
Collaborator

Hey @tmilewski - the snapshot version command generated the following package versions:

Package Version
@clerk/elements 0.10.0-snapshot.vd1e7a32
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/remix 4.2.0-snapshot.vd1e7a32
@clerk/ui 0.1.6-snapshot.vd1e7a32

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/elements

npm i @clerk/elements@0.10.0-snapshot.vd1e7a32 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/remix

npm i @clerk/remix@4.2.0-snapshot.vd1e7a32 --save-exact

@clerk/ui

npm i @clerk/ui@0.1.6-snapshot.vd1e7a32 --save-exact

@tmilewski
tmilewski enabled auto-merge (squash) July 1, 2024 21:08
@tmilewski
tmilewski merged commit 168607a into main Jul 1, 2024
@tmilewski
tmilewski deleted the tm.elements/fix-forgot-password-loading branch July 1, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants